Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8367/03240ad7 backport][stable-8] fix(opentelemetry): close span even if no logs are sent #8389

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented May 19, 2024

This is a backport of PR #8367 as merged into main (03240ad).

SUMMARY

Fixes a regression caused by #6531

So spans were not closed when sending logs were disabled.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

opentelemetry

ADDITIONAL INFORMATION

* fix(opentelemetry): close span even if no logs are sent

* changelog

(cherry picked from commit 03240ad)
@ansibullbot
Copy link
Collaborator

cc @v1v
click here for bot help

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug callback callback plugin new_contributor Help guide this first time contributor plugins plugin (any type) labels May 19, 2024
@felixfontein felixfontein merged commit eff8ca8 into stable-8 May 19, 2024
131 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-8/03240ad7dc57aefc14b1ceba3e08abec0c62500b/pr-8367 branch May 19, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug This issue/PR relates to a bug callback callback plugin new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants