fix(opentelemetry): close span even if no logs are sent #8367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
added
check-before-release
ansibullbot
added
bug
|
Looks good to me! If nobody objects, I'll merge this this weekend. |
felixfontein
removed
the
check-before-release
felixfontein
merged commit 03240ad
into
ansible-collections:main
132 of 133 checks passed
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #8388 🤖 @patchback |
|
@v1v thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
May 19, 2024
* fix(opentelemetry): close span even if no logs are sent * changelog (cherry picked from commit 03240ad)
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8389 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 19, 2024
* fix(opentelemetry): close span even if no logs are sent * changelog (cherry picked from commit 03240ad)
felixfontein
pushed a commit
that referenced
this pull request
May 19, 2024
… even if no logs are sent (#8388) fix(opentelemetry): close span even if no logs are sent (#8367) * fix(opentelemetry): close span even if no logs are sent * changelog (cherry picked from commit 03240ad) Co-authored-by: Victor Martinez <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
May 19, 2024
… even if no logs are sent (#8389) fix(opentelemetry): close span even if no logs are sent (#8367) * fix(opentelemetry): close span even if no logs are sent * changelog (cherry picked from commit 03240ad) Co-authored-by: Victor Martinez <[email protected]>
austinlucaslake
pushed a commit
to austinlucaslake/community.general
that referenced
this pull request
May 25, 2024
…ections#8367) * fix(opentelemetry): close span even if no logs are sent * changelog
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
…ections#8367) * fix(opentelemetry): close span even if no logs are sent * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a regression caused by #6531
So spans were not closed when sending logs were disabled.
ISSUE TYPE
COMPONENT NAME
opentelemetryADDITIONAL INFORMATION