Refactor consul_session to support authentication with tokens #6755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
the
needs_revision
felixfontein
added
check-before-release
ansibullbot
removed
WIP
valeriopoggi
pushed a commit
to valeriopoggi/community.general
that referenced
this pull request
Jun 22, 2023
There was a problem hiding this comment.
Could you please add a changelog fragment? I think this is more a new feature than a bugfix since it's basically rewriting the module. Please use a minor_changes section in the changelog fragment.
changelogs/fragments/6755-refactor-consul-session-to-use-requests-lib-instead-of-consul.yml
Outdated
Show resolved
Hide resolved
…sts-lib-instead-of-consul.yml Co-authored-by: Felix Fontein <[email protected]>
ansibullbot
added
needs_ci
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
merge_commit
valeriopoggi
force-pushed
the
update-consul-session
branch
from
5427dc7 to
49b8941
Compare
ansibullbot
removed
merge_commit
|
If nobody objects (and assuming that CI passes), I'll merge this by the end of this week. |
felixfontein
removed
the
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6879 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
* Split into separate PR * Refactor test, add author to inactive maintainers * Add changelog fragment and correct requirements section on module documentation * Add changelog fragment and correct requirements section on module documentation * Update changelogs/fragments/6755-refactor-consul-session-to-use-requests-lib-instead-of-consul.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Valerio Poggi <vrpoggigmail.com> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 242258e)
|
@valeriopoggi @Hakon thank you very much for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Jul 7, 2023
…port authentication with tokens (#6879) Refactor consul_session to support authentication with tokens (#6755) * Split into separate PR * Refactor test, add author to inactive maintainers * Add changelog fragment and correct requirements section on module documentation * Add changelog fragment and correct requirements section on module documentation * Update changelogs/fragments/6755-refactor-consul-session-to-use-requests-lib-instead-of-consul.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Valerio Poggi <vrpoggigmail.com> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 242258e) Co-authored-by: Valerio Poggi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Split from #6715 as per PR comments. This was originally part of #5320 by @Hakon.
Refactor consul_session module to use requests and the HTTP API due to an issue in a 3rd party lib.
ISSUE TYPE
COMPONENT NAME
consul_session