Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add consul_policy module from dormant PR #6715

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Add consul_policy module from dormant PR #6715

merged 1 commit into from
Jul 12, 2023

Conversation

valeriopoggi
Copy link
Contributor

@valeriopoggi valeriopoggi commented Jun 16, 2023 •
edited
Loading

SUMMARY

Resubmitting parts of #5320 originally from Hakon, as per PR comments.

Fixes: #1749

ISSUE TYPE
  • New Module/Plugin Pull Request
COMPONENT NAME

consul_policy

@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot
Copy link
Collaborator

cc @sgargan
click here for bot help

@ansibullbot ansibullbot added integration tests/integration module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Jun 16, 2023
@ansibullbot

This comment was marked as outdated.

Sign in to view
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 labels Jun 18, 2023
felixfontein
felixfontein reviewed Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@valeriopoggi valeriopoggi marked this pull request as draft June 19, 2023 22:07
@ansibullbot ansibullbot added the WIP Work in progress label Jun 19, 2023
@valeriopoggi valeriopoggi mentioned this pull request Jun 20, 2023
Merged
@valeriopoggi valeriopoggi changed the title Consul policy Add consul_policy module from dormant PR Jun 20, 2023
@valeriopoggi valeriopoggi marked this pull request as ready for review June 20, 2023 18:35
@ansibullbot ansibullbot removed the WIP Work in progress label Jun 20, 2023
@valeriopoggi valeriopoggi marked this pull request as draft June 21, 2023 07:54
@ansibullbot ansibullbot added the WIP Work in progress label Jun 21, 2023
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot
Copy link
Collaborator

@valeriopoggi this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jun 29, 2023
@ansibullbot ansibullbot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jul 5, 2023
@valeriopoggi valeriopoggi marked this pull request as ready for review July 5, 2023 21:38
@ansibullbot ansibullbot removed WIP Work in progress needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jul 5, 2023
@patchback patchback bot mentioned this pull request Jul 7, 2023
Merged
@felixfontein
Copy link
Collaborator

Please rebase now that #6755 has been merged so that the changes from that PR no longer show up under "Files changed".

@ansibullbot ansibullbot removed the new_contributor Help guide this first time contributor label Jul 7, 2023
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jul 7, 2023
@ansibullbot ansibullbot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jul 8, 2023
@felixfontein felixfontein merged commit 33af903 into ansible-collections:main Jul 12, 2023
@patchback
Copy link

patchback bot commented Jul 12, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/33af903b24906ffa6ffe8e3d10979df98e57eb57/pr-6715

Backported as #6917

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 12, 2023
patchback bot pushed a commit that referenced this pull request Jul 12, 2023
@valeriopoggi @patchback
Add consul_policy module from dormant PR (#6715)
a350306 
Squash commits to make rebasing easier

Co-authored-by: Valerio Poggi <vrpoggigmail.com>
(cherry picked from commit 33af903)
@patchback patchback bot mentioned this pull request Jul 12, 2023
Merged
@felixfontein
Copy link
Collaborator

@Hakon @valeriopoggi thanks a lot for your contribution!

felixfontein pushed a commit that referenced this pull request Jul 12, 2023
@patchback @valeriopoggi
[PR #6715/33af903b backport][stable-7] Add consul_policy module from …
ce30e07 
…dormant PR (#6917)

Add consul_policy module from dormant PR (#6715)

Squash commits to make rebasing easier

Co-authored-by: Valerio Poggi <vrpoggigmail.com>
(cherry picked from commit 33af903)

Co-authored-by: Valerio Poggi <[email protected]>
@valeriopoggi valeriopoggi deleted the consul-policy branch July 12, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consul_acl in legacy mode only
3 participants
@valeriopoggi @ansibullbot @felixfontein