opkg: remove useless default value for force #6513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
felixfontein
added
check-before-release
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
May 14, 2023
felixfontein
removed
the
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6590 🤖 @patchback |
|
@russoz thanks! |
patchback bot
pushed a commit
that referenced
this pull request
May 29, 2023
* opkg: remove useless default value for force * add changelog frag * Update changelogs/fragments/6513-opkg-default-force.yml Co-authored-by: Felix Fontein <[email protected]> * add to force param description * typo --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit e588e67)
felixfontein
pushed a commit
that referenced
this pull request
May 29, 2023
…alue for force (#6590) opkg: remove useless default value for force (#6513) * opkg: remove useless default value for force * add changelog frag * Update changelogs/fragments/6513-opkg-default-force.yml Co-authored-by: Felix Fontein <[email protected]> * add to force param description * typo --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit e588e67) Co-authored-by: Alexei Znamensky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This module has a legacy value
""for theforceparameter. Whenforce=""the module does not pass any CLI "force" option to the underlyingopkgcommand. The same happens ifforce=null.So, the option
""and it being marked as default value is something that was arguably created to artificially indicate that the parameter is optional.This PR removes the default, and given that both values
""andnullwill trigger the same behaviour in the module, this change is completely transparent to users.A follow-up PR will then deprecate the option
"", on the account that some users may be calling the module explicitly passing the empty string as parameter.ISSUE TYPE
COMPONENT NAME
opkg