opkg: remove useless default value for force (#6513)

* opkg: remove useless default value for force * add changelog frag * Update changelogs/fragments/6513-opkg-default-force.yml Co-authored-by: Felix Fontein <[email protected]> * add to force param description * typo --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit e588e67)
ansible-collections · May 29, 2023 · a2c36e6 · a2c36e6
1 parent fce8eac
commit a2c36e6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/changelogs/fragments/6513-opkg-default-force.yml b/changelogs/fragments/6513-opkg-default-force.yml
@@ -0,0 +1,2 @@
+minor_changes:
+  - opkg - remove default value ``""`` for parameter ``force`` as it causes the same behaviour of not having that parameter (https://github.com/ansible-collections/community.general/pull/6513).
diff --git a/plugins/modules/opkg.py b/plugins/modules/opkg.py
@@ -46,6 +46,8 @@
     force:
         description:
             - The C(opkg --force) parameter used.
+            - Passing C("") as value and not passing any value at all have both
+              the same effect of B(not) using any C(--force-) parameter.
         choices:
             - ""
             - "depends"
@@ -58,7 +60,6 @@
             - "remove"
             - "checksum"
             - "removal-of-dependent-packages"
-        default: ""
         type: str
     update_cache:
         description:
@@ -114,8 +115,8 @@ class Opkg(StateModuleHelper):
         argument_spec=dict(
             name=dict(aliases=["pkg"], required=True, type="list", elements="str"),
             state=dict(default="present", choices=["present", "installed", "absent", "removed"]),
-            force=dict(default="", choices=["", "depends", "maintainer", "reinstall", "overwrite", "downgrade", "space", "postinstall", "remove",
-                                            "checksum", "removal-of-dependent-packages"]),
+            force=dict(choices=["", "depends", "maintainer", "reinstall", "overwrite", "downgrade", "space",
+                                "postinstall", "remove", "checksum", "removal-of-dependent-packages"]),
             update_cache=dict(default=False, type='bool'),
         ),
     )
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		minor_changes:
		- opkg - remove default value ``""`` for parameter ``force`` as it causes the same behaviour of not having that parameter (https://github.com/ansible-collections/community.general/pull/6513).