Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #3284/69641d36 backport][stable-3] openwrt_init - improvements #3287

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Aug 28, 2021

This is a backport of PR #3284 as merged into main (69641d3).

SUMMARY

Generic improvements on openwrt_init: pythonification + run_command with list of args instead of string

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/system/openwrt_init.py

* improvements on openwrt_init

* added changelog fragment

(cherry picked from commit 69641d3)
@patchback patchback bot mentioned this pull request Aug 28, 2021
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug community_review module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging system labels Aug 28, 2021
@felixfontein felixfontein merged commit 9651bca into stable-3 Aug 28, 2021
@felixfontein felixfontein deleted the patchback/backports/stable-3/69641d36e18c5a62d966dc24db28d2a0d28b9bda/pr-3284 branch August 28, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants