Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openwrt_init - improvements #3284

Merged
merged 2 commits into from
Aug 28, 2021
Merged

openwrt_init - improvements #3284

merged 2 commits into from
Aug 28, 2021

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Aug 28, 2021

SUMMARY

Generic improvements on openwrt_init: pythonification + run_command with list of args instead of string

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/system/openwrt_init.py

felixfontein
felixfontein approved these changes Aug 28, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on a first glance.

@felixfontein felixfontein added backport-3 check-before-release PR will be looked at again shortly before release and merged if possible. labels Aug 28, 2021
@ansibullbot
Copy link
Collaborator

cc @agaffney
click here for bot help

@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug community_review module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging system labels Aug 28, 2021
@agaffney
Copy link

This looks good to me

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Aug 28, 2021
@felixfontein felixfontein merged commit 69641d3 into ansible-collections:main Aug 28, 2021
@patchback
Copy link

patchback bot commented Aug 28, 2021 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/69641d36e18c5a62d966dc24db28d2a0d28b9bda/pr-3284

Backported as #3287

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 28, 2021
@russoz
openwrt_init - improvements (#3284)
e091ae1 
* improvements on openwrt_init

* added changelog fragment

(cherry picked from commit 69641d3)
@felixfontein
Copy link
Collaborator

@russoz thanks for fixing/improving this!
@agaffney thanks for reviewing!

@patchback patchback bot mentioned this pull request Aug 28, 2021
Merged
felixfontein pushed a commit that referenced this pull request Aug 28, 2021
@patchback @russoz
openwrt_init - improvements (#3284) (#3287)
9651bca 
* improvements on openwrt_init

* added changelog fragment

(cherry picked from commit 69641d3)

Co-authored-by: Alexei Znamensky <[email protected]>
@russoz russoz deleted the openwrt_init-cleanup branch August 28, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@russoz @ansibullbot @agaffney @felixfontein