snap module fails with state absent on snap that is not installed

[jkman340]

Summary

Using snap module to ensure a snap is not installed on system. Task fails with error "No snap matching 'foo' available."

Issue Type

Bug Report

Component Name

community.general.snap

Ansible Version

ansible 2.10.5
config file = /etc/ansible/ansible.cfg
configured module search path = ['/home/user/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /usr/lib/python3/dist-packages/ansible
executable location = /usr/bin/ansible
python version = 3.6.9 (default, Jan 26 2021, 15:33:00) [GCC 8.4.0]

### Configuration

```console (paste below)
$ ansible-config dump --only-changed

ANSIBLE_PIPELINING(/etc/ansible/ansible.cfg) = True

OS / Environment

Ubuntu 18.04

Steps to Reproduce

- community.general.snap:
     name: 
       - foo
     state: absent

Expected Results

Module to pass with OK (not changed)

Actual Results

Module fails with error above

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[jkman340]

Same as this closed issue #1433 but does not work for me. Confirmed snapd is running on remote system.

[quidame]

!component =plugins/modules/packaging/os/snap.py

[ansibullbot]

cc @angristan @vcarceler
click here for bot help

[aminvakil]

Taking a quick look at code it seems that it fails here:

community.general/plugins/modules/packaging/os/snap.py

Line 229 in 1ed4394

self.validate_input_snaps() # if snap doesnt exist, it will be absent by definition

which calls here:

community.general/plugins/modules/packaging/os/snap.py

Lines 189 to 193 in 1ed4394

	def validate_input_snaps(self):
	"""Ensure that all exist."""
	for snap_name in self.vars.name:
	if not self.snap_exists(snap_name):
	raise ModuleHelperException(msg="No snap matching '%s' available." % snap_name)

which checks this:

community.general/plugins/modules/packaging/os/snap.py

Lines 172 to 173 in 1ed4394

	def snap_exists(self, snap_name):
	return 0 == self.run_command(params=[{'state': 'info'}, {'name': [snap_name]}])[0]

I guess it's fine to fail if package does not exist in snap repository, does snap return non-zero if package exists in snap repository but it isn't installed when executing snap info pkg?

[felixfontein]

Please note that the snap module in the main branch is pretty much different from the one in stable-3, since the backport #2542 hasn't yet been merged. (I accidentally merged the original PR too early; I'm still waiting for someone to test the backport before merging it.)

[felixfontein]

I think this is also fixed by #2912.