Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'servers' to 'server' for nameserver_*info; add 'server' parameter to wait_for_txt #178

Merged

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Update #168 to use the same parameter names as for the lookup plugins. Also add the new server parameter to wait_for_txt.

CC @hakong

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

nameserver_info
nameserver_record_info
wait_for_txt

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1da3477) 96.82% compared to head (c81cfa7) 96.82%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files         107      107           
  Lines        7395     7395           
  Branches     1037     1037           
=======================================
  Hits         7160     7160           
  Misses        169      169           
  Partials       66       66           
Flag Coverage Δ
integration 40.62% <ø> (-0.04%) ⬇️
sanity 31.56% <ø> (ø)
units 96.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 29, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.dns/branch/main

@felixfontein felixfontein merged commit 4a5b58b into ansible-collections:main Dec 29, 2023
50 checks passed
@felixfontein felixfontein deleted the wait_for_txt-server branch December 29, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant