-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce server specification in nameserver_info module #168
Introduce server specification in nameserver_info module #168
Conversation
Enhanced the ResolveDirectlyFromNameServers class to accept a new argument 'server_addresses'. This allows specifying custom DNS servers for resolution, overriding the default nameservers. Adjusted the constructor and relevant methods to handle the provided server addresses.
Modified the nameserver_info module to include a new 'servers' parameter, enabling users to specify custom DNS servers for nameserver resolution. Updated argument_spec in AnsibleModule initialization and adjusted resolver initialization to use the provided server addresses.
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 96.81% 96.81%
=======================================
Files 107 107
Lines 7349 7349
Branches 1022 1022
=======================================
Hits 7115 7115
Misses 167 167
Partials 67 67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@felixfontein Does this look OK? I need is to be able to specify the nameserver to contact. I've tested this and it seems to work fine.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Can you please add a changelog fragment? Also would you mind making the same changes to the nameserver_record_info
module?
Removed required: and default:, added version_added. Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
I'll do my best. As you can probably see I'm not very experienced, so I'll take all the help I can get :) |
Restarting CI (so that integration tests run). |
module.params['servers'] directly
integration tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One little update to the changelog fragment, then it should be done!
Co-authored-by: Felix Fontein <[email protected]>
@hakong thanks for your contribution! |
I've decided to rename |
SUMMARY
This merge request introduces the ability to specify custom DNS servers for resolving nameserver information in the nameserver_info module. It includes enhancements to the ResolveDirectlyFromNameServers class to handle custom server addresses and updates the nameserver_info module to accept a new 'servers' parameter.
ISSUE TYPE
COMPONENT NAME
community.dns.nameserver_info
ADDITIONAL INFORMATION