s3_bucket/test: use one bucket per scenario #345

goneri · 2021-04-27T18:54:24Z

To speed up the execution, we run all the tests in parallel. This commit
ensures each playbook uses a different bucket, this to avoid any
unexpected side-effect.

To speed up the execution, we run all the tests in parallel. This commit ensures each playbook uses a different bucket, this to avoid any unexpected side-effect.

ansibullbot · 2021-04-27T18:54:56Z

@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

ansibullbot · 2021-04-27T18:54:56Z

cc @jillr @s-hertel @tremble @wimnat
click here for bot help

jillr

Thanks @goneri!

tremble

There's a much less invasive option:

in tests/integration/targets/s3_bucket/roles/s3_bucket/defaults.yml

bucket_name: '{{ resource_prefix | hash("md5") }}{{ suffix_override | default("-" + inventory_hostname) }}'

For dotted we can set update the inventory:
tests/integration/targets/s3_bucket/inventory

dotted suffix_override=".dotted"

tremble

since the change works let's get this merged to unblock #311

…lections#345) (ansible-collections#372) * implement tags feature for NAT gateway * add integration test tasks for tags feature * refactor integration tests (overall) removing hard-coded parameters * add missing integration test tasks without CHECK_MODE * include until loop for some tasks as they failed during the integration * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None * removed tests in check_mode because not working due to DRY_RUN_GATEWAY * Addressed reviewers comments Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b7afd18

…lections#345) (ansible-collections#372) * implement tags feature for NAT gateway * add integration test tasks for tags feature * refactor integration tests (overall) removing hard-coded parameters * add missing integration test tasks without CHECK_MODE * include until loop for some tasks as they failed during the integration * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None * removed tests in check_mode because not working due to DRY_RUN_GATEWAY * Addressed reviewers comments Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws -- 238 -- See: ansible-collections/community.aws@b7afd18

…lections#345) (ansible-collections#372) * implement tags feature for NAT gateway * add integration test tasks for tags feature * refactor integration tests (overall) removing hard-coded parameters * add missing integration test tasks without CHECK_MODE * include until loop for some tasks as they failed during the integration * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None * removed tests in check_mode because not working due to DRY_RUN_GATEWAY * Addressed reviewers comments Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b7afd18

* implement tags feature for NAT gateway * add integration test tasks for tags feature * refactor integration tests (overall) removing hard-coded parameters * add missing integration test tasks without CHECK_MODE * include until loop for some tasks as they failed during the integration * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None * removed tests in check_mode because not working due to DRY_RUN_GATEWAY * Addressed reviewers comments Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b7afd18

…lections#345) (ansible-collections#372) * implement tags feature for NAT gateway * add integration test tasks for tags feature * refactor integration tests (overall) removing hard-coded parameters * add missing integration test tasks without CHECK_MODE * include until loop for some tasks as they failed during the integration * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None * removed tests in check_mode because not working due to DRY_RUN_GATEWAY * Addressed reviewers comments Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b7afd18

s3_bucket/test: use one bucket per scenario Reviewed-by: Ansibullbot manages ticket workflow https://github.com/ansibullbot (cherry picked from commit 654a45c)

…lections#345) (ansible-collections#372) * implement tags feature for NAT gateway * add integration test tasks for tags feature * refactor integration tests (overall) removing hard-coded parameters * add missing integration test tasks without CHECK_MODE * include until loop for some tasks as they failed during the integration * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None * removed tests in check_mode because not working due to DRY_RUN_GATEWAY * Addressed reviewers comments Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: Alina Buzachis <[email protected]>

s3_bucket/test: use one bucket per scenario

f709443

To speed up the execution, we run all the tests in parallel. This commit ensures each playbook uses a different bucket, this to avoid any unexpected side-effect.

This was referenced Apr 27, 2021

s3: raise an error if the bucket name is not correct #344

Closed

s3: raise an error if the bucket name is not correct #341

Merged

add object ownership controls options for s3 bucket #311

Merged

jillr approved these changes Apr 27, 2021

View reviewed changes

tremble reviewed Apr 28, 2021

View reviewed changes

tremble approved these changes Apr 29, 2021

View reviewed changes

tremble added gate and removed needs_info This issue requires further information. Please answer any outstanding questions labels Apr 29, 2021

ansibullbot added needs_info This issue requires further information. Please answer any outstanding questions and removed needs_triage labels Apr 29, 2021

ansible-zuul bot merged commit 654a45c into ansible-collections:main Apr 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

s3_bucket/test: use one bucket per scenario #345

s3_bucket/test: use one bucket per scenario #345

goneri commented Apr 27, 2021

ansibullbot commented Apr 27, 2021

ansibullbot commented Apr 27, 2021

jillr left a comment

tremble left a comment

tremble left a comment •

edited

Loading

s3_bucket/test: use one bucket per scenario #345

s3_bucket/test: use one bucket per scenario #345

Conversation

goneri commented Apr 27, 2021

ansibullbot commented Apr 27, 2021

ansibullbot commented Apr 27, 2021

jillr left a comment

Choose a reason for hiding this comment

tremble left a comment

Choose a reason for hiding this comment

tremble left a comment • edited Loading

Choose a reason for hiding this comment

tremble left a comment •

edited

Loading