Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3: raise an error if the bucket name is not correct #344

Closed
wants to merge 1 commit into from
Closed

s3: raise an error if the bucket name is not correct #344

wants to merge 1 commit into from

Conversation

goneri
Copy link
Member

@goneri goneri commented Apr 27, 2021 •
edited
Loading

Depends-On: #345

Ensure the name of the bucket does not go above 63 characters and some other checks.

Also, ensure the .bucket bucket is removed properly.

See: https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html

@goneri
s3: raise an error if the bucket name is not correct
44fa7a4 
Ensure the name of the bucket does not go above 63 characters
and some other checks.

Also, ensure the .bucket bucket is removed properly.

See: https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html
@ansibullbot
Copy link

@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot
Copy link

cc @jillr @lwade @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added integration tests/integration module module module_utils module_utils needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage plugins plugin (any type) tests tests labels Apr 27, 2021
@goneri goneri closed this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
integration tests/integration module_utils module_utils module module needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goneri @ansibullbot