[PR #1505/116f882f backport][stable-5] Ensure ec2_instance tests filter correctly #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Ensure ec2_instance tests filter correctly SUMMARY Multiple instances test picks up instances from other tests when run concurrently. Use tag filters to prevent this. ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/ec2_instance_instance_multiple/tasks/main.yml ADDITIONAL INFORMATION in the example here: https://39d585ceb0884fd58f3d-34626b4834f21056500b5be2783f089d.ssl.cf5.rackcdn.com/1500/eb91ab4ac10d4af904d629a7296502aff59d9d06/check/integration-amazon.aws-1/86d0d4c/job-output.txt the Create multiple instance (check_mode) task erroneously picks up instances from the ec2_instance_instance_minimal test target. Reviewed-by: Alina Buzachis (cherry picked from commit 116f882)
alinabuzachis
approved these changes
May 3, 2023
tremble
approved these changes
May 3, 2023
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 55s |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-5/116f882fd2ee1e1694dd9ac92d79c6a5fc0a5f59/pr-1505
branch
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…1506) Migrate elb_application_lb module to amazon.aws SUMMARY Remove elb_application_lb* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Bikouo Aubin <None> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…1506) Migrate elb_application_lb module to amazon.aws SUMMARY Remove elb_application_lb* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Bikouo Aubin <None> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…1506) Migrate elb_application_lb module to amazon.aws SUMMARY Remove elb_application_lb* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Bikouo Aubin <None> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1505 as merged into main (116f882).
SUMMARY
Multiple instances test picks up instances from other tests when run concurrently. Use tag filters to prevent this.
ISSUE TYPE
COMPONENT NAME
tests/integration/targets/ec2_instance_instance_multiple/tasks/main.yml
ADDITIONAL INFORMATION
in the example here: https://39d585ceb0884fd58f3d-34626b4834f21056500b5be2783f089d.ssl.cf5.rackcdn.com/1500/eb91ab4ac10d4af904d629a7296502aff59d9d06/check/integration-amazon.aws-1/86d0d4c/job-output.txt
the
Create multiple instance (check_mode)task erroneously picks up instances from the ec2_instance_instance_minimal test target.