Ensure ec2_instance tests filter correctly #1505
Conversation
|
WIP includes a change to the module to ensure all ec2_instance related targets are run at least once. This will be reverted assuming it passes. |
jillr
force-pushed
the
ec2_instance_test_collisions
branch
from
b0d982d to
bb7a847
Compare
Multiple instances test picks up instances from other tests when run concurrently. Use tag filters to prevent this.
jillr
force-pushed
the
ec2_instance_test_collisions
branch
from
bb7a847 to
29d942b
Compare
|
Tests passing with all ec2_instance targets: https://ansible.softwarefactory-project.io/zuul/buildset/54174d7b05e5493eb09e561052140856 |
jillr
changed the title
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 47s |
alinabuzachis
added
mergeit
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 02s |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1506 🤖 @patchback |
Ensure ec2_instance tests filter correctly SUMMARY Multiple instances test picks up instances from other tests when run concurrently. Use tag filters to prevent this. ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/ec2_instance_instance_multiple/tasks/main.yml ADDITIONAL INFORMATION in the example here: https://39d585ceb0884fd58f3d-34626b4834f21056500b5be2783f089d.ssl.cf5.rackcdn.com/1500/eb91ab4ac10d4af904d629a7296502aff59d9d06/check/integration-amazon.aws-1/86d0d4c/job-output.txt the Create multiple instance (check_mode) task erroneously picks up instances from the ec2_instance_instance_minimal test target. Reviewed-by: Alina Buzachis (cherry picked from commit 116f882)
[PR #1505/116f882f backport][stable-5] Ensure ec2_instance tests filter correctly This is a backport of PR #1505 as merged into main (116f882). SUMMARY Multiple instances test picks up instances from other tests when run concurrently. Use tag filters to prevent this. ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/ec2_instance_instance_multiple/tasks/main.yml ADDITIONAL INFORMATION in the example here: https://39d585ceb0884fd58f3d-34626b4834f21056500b5be2783f089d.ssl.cf5.rackcdn.com/1500/eb91ab4ac10d4af904d629a7296502aff59d9d06/check/integration-amazon.aws-1/86d0d4c/job-output.txt the Create multiple instance (check_mode) task erroneously picks up instances from the ec2_instance_instance_minimal test target. Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell
SUMMARY
Multiple instances test picks up instances from other tests when run concurrently. Use tag filters to prevent this.
ISSUE TYPE
COMPONENT NAME
tests/integration/targets/ec2_instance_instance_multiple/tasks/main.yml
ADDITIONAL INFORMATION
in the example here: https://39d585ceb0884fd58f3d-34626b4834f21056500b5be2783f089d.ssl.cf5.rackcdn.com/1500/eb91ab4ac10d4af904d629a7296502aff59d9d06/check/integration-amazon.aws-1/86d0d4c/job-output.txt
the
Create multiple instance (check_mode)task erroneously picks up instances from the ec2_instance_instance_minimal test target.