Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate validator set update vote extensions into ProcessProposal #372

Merged

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented Aug 21, 2022

Implements the fourth item of issue #242

@sug0 sug0 force-pushed the tiago/ethbridge/valset-update-process-proposal branch 7 times, most recently from f1a8a5d to 1904812 Compare August 25, 2022 18:31
@sug0 sug0 force-pushed the tiago/ethbridge/valset-update-process-proposal branch from c018ae5 to 6a17bf8 Compare August 26, 2022 10:17
@sug0 sug0 marked this pull request as ready for review September 5, 2022 11:41
@sug0
Copy link
Collaborator Author

sug0 commented Sep 5, 2022

opened this PR for review since it was already integrated into tiago/ethbridge/shim-vext anyway. it should be somewhat ready, aside from the odd unit test, which can be addressed in the future shimming PR

Copy link
Contributor

@james-chf james-chf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this and then test/review everything as whole when the shim is merged in. I need to check my understanding of how validator set updates will be submitted on Namada chain in the new design.

@sug0 sug0 merged commit 1800cf8 into eth-bridge-integration Sep 7, 2022
@sug0 sug0 deleted the tiago/ethbridge/valset-update-process-proposal branch September 7, 2022 07:46
phy-chain pushed a commit to phy-chain/namada that referenced this pull request Mar 1, 2024
* Implement faucet transfers in interface

* Hook up UI

* hook up faucet to slice, finish form

* Faucet transfers for Ledger HW wallet

* Fix signing for keypair accounts (non-Ledger)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants