Ensure we sign valset upd vexts with the correct key kind

anoma · Aug 26, 2022 · 03904d7 · 03904d7
1 parent e86491a
commit 03904d7
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/shared/src/types/vote_extensions/validator_set_update.rs b/shared/src/types/vote_extensions/validator_set_update.rs
@@ -99,12 +99,16 @@ pub struct Vext {
 }
 
 impl Vext {
-    /// Creates a new signed [`Vext`].
+    /// Ensures `sk` is a Secp256k1 key, then creates a new signed [`Vext`].
     ///
     /// For more information, read the docs of [`SignedVext::new`].
     #[inline]
-    pub fn sign(&self, sk: &common::SecretKey) -> SignedVext {
-        SignedVext::new(sk, self.clone())
+    pub fn sign(&self, sk: &common::SecretKey) -> Option<SignedVext> {
+        use common::SecretKey::*;
+        match sk {
+            Secp256k1(_) => Some(SignedVext::new(sk, self.clone())),
+            _ => None,
+        }
     }
 }