forked from CrayLabs/SmartSim
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable specifying target hostname(s) when starting tasks #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36e0b1a
to
19d35ab
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 736-2 #17 +/- ##
========================================
Coverage ? 49.17%
========================================
Files ? 90
Lines ? 6926
Branches ? 0
========================================
Hits ? 3406
Misses ? 3520
Partials ? 0
|
f42bbfa
to
81a59b0
Compare
108046e
to
a269186
Compare
0228f9f
to
d52c74d
Compare
- Enables using multiple feature stores by enhancing the existing tensor/model-key classes to include the feature store descriptor. - Update the `EnvironmentConfigLoader` to retrieve _multiple_ feature stores from environment using the prior key as a prefix to query with - Minor (lift & shift) refactor of top-level functions in worker manager module to reduce number of touch-points for converting to `FeatureStoreKey` from capnproto type - now, only `worker.py` deals with this conversion. [ committed by @ankona] [ approved by @mellis13 @AlyssaCote @al-rigazzi ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n/t