Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable specifying target hostname(s) when starting tasks #17

Closed
wants to merge 4 commits into from
Closed

Conversation

ankona
Copy link
Owner

@ankona ankona commented Jul 24, 2024

n/t

@ankona ankona force-pushed the 736-2 branch 6 times, most recently from 36e0b1a to 19d35ab Compare July 29, 2024 14:35
@ankona ankona changed the title 740 Enable specifying target hostname(s) when starting tasks Jul 29, 2024
@ankona ankona closed this Jul 29, 2024
@ankona ankona reopened this Jul 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 2.20994% with 177 lines in your changes missing coverage. Please review.

Please upload report for BASE (736-2@85a6ee0). Learn more about missing BASE report.

Files Patch % Lines
smartsim/_core/launcher/dragon/pqueue.py 0.00% 118 Missing ⚠️
smartsim/_core/launcher/dragon/dragonBackend.py 0.00% 57 Missing ⚠️
smartsim/_core/launcher/step/dragonStep.py 0.00% 1 Missing ⚠️
smartsim/settings/dragonRunSettings.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             736-2      #17   +/-   ##
========================================
  Coverage         ?   49.17%           
========================================
  Files            ?       90           
  Lines            ?     6926           
  Branches         ?        0           
========================================
  Hits             ?     3406           
  Misses           ?     3520           
  Partials         ?        0           
Files Coverage Δ
smartsim/_core/launcher/dragon/dragonLauncher.py 23.48% <ø> (ø)
smartsim/_core/schemas/dragonRequests.py 79.36% <100.00%> (ø)
smartsim/_core/launcher/step/dragonStep.py 36.50% <0.00%> (ø)
smartsim/settings/dragonRunSettings.py 62.06% <66.66%> (ø)
smartsim/_core/launcher/dragon/dragonBackend.py 0.00% <0.00%> (ø)
smartsim/_core/launcher/dragon/pqueue.py 0.00% <0.00%> (ø)

ankona added 3 commits August 7, 2024 16:23
- Enables using multiple feature stores by enhancing the existing
tensor/model-key classes to include the feature store descriptor.
- Update the `EnvironmentConfigLoader` to retrieve _multiple_ feature
stores from environment using the prior key as a prefix to query with
- Minor (lift & shift) refactor of top-level functions in worker manager
module to reduce number of touch-points for converting to
`FeatureStoreKey` from capnproto type
    - now, only `worker.py` deals with this conversion.

[ committed by @ankona]
[ approved by @mellis13 @AlyssaCote @al-rigazzi ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants