-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FeatureStore descriptor to tensor & model keys #633
Conversation
6c4320d
to
1d110ae
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mli-feature #633 +/- ##
==============================================
Coverage ? 65.21%
==============================================
Files ? 97
Lines ? 6840
Branches ? 0
==============================================
Hits ? 4461
Misses ? 2379
Partials ? 0
|
93d2380
to
bf32f12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving these changes!! Really my only request is that we update files pertaining to the mli_driver
so that we can run it without it crashing and burning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of initial comments/questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per our recent conversation, I am sorry you had to tie up so many loose ends created by the hacky solutions. I'll review the PR again once previous comments are addressed.
36e0b1a
to
19d35ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the changes! Just a few small cleanup comments.
smartsim/_core/mli/infrastructure/storage/dragonfeaturestore.py
Outdated
Show resolved
Hide resolved
smartsim/_core/mli/infrastructure/storage/dragonfeaturestore.py
Outdated
Show resolved
Hide resolved
cf50cc1
to
108046e
Compare
EnvironmentConfigLoader
to retrieve multiple feature stores from environment using the prior key as a prefix to query withFeatureStoreKey
from capnproto typeworker.py
deals with this conversion.