-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move syntax grammars to TS definitions #592
Conversation
This commit refactors remaining existing grammars to use TS definitions as started in angular#581.
@dannymcgee if you'd like to take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think the generated syntax files should be checked in along with the source that generates them. (TypeScript repo also does this with their compiled Javascript output)
This would make it
- much easier to inspect the compiled syntaxes,
- helpful to check the diff with existing file, (there should not be any in this PR, I guess?)
- simplify the build process. At build time they just have to the copied to the dist folder.
We just need to make sure the CI system checks the generated files to ensure they are in sync with the source.
What do you think?
That sounds good. Do you mind if I put that in the next PR? It goes well with putting the generated files in the root syntaxes directory, which makes development easier as well. |
Yeah separate PR is fine, thank you! |
Sorry I'm just seeing this, but looks good to me! The only thing I would note for the next PR is that if we're going to use PascalCase for the grammar identifiers we should probably also rename |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit refactors remaining existing grammars to use TS definitions
as started in #581.