refactor: build template.json grammar from typescript source files #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I will take a look tonight; apologies for the tardiness. |
No worries, and no rush! |
ayazhafiz
suggested changes
Jan 26, 2020
ayazhafiz
reviewed
Jan 27, 2020
The grammars are actually copied from syntaxes/out to dist/syntaxes as part of the build script, per ad747b9 |
ayazhafiz
approved these changes
Jan 28, 2020
| if (typeof value === 'string') { | ||
| processedGrammar[key] = value; | ||
| } else if (value instanceof RegExp) { | ||
| // Escape backslashes/quote marks and trim the demarcating `/` characters from a regex literal |
ayazhafiz
added a commit
to ayazhafiz/vscode-ng-language-service
that referenced
this pull request
Jan 29, 2020
This commit refactors remaining existing grammars to use TS definitions as started in angular#581.
ayazhafiz
added a commit
that referenced
this pull request
Jan 29, 2020
* refactor: move syntax grammars to TS definitions This commit refactors remaining existing grammars to use TS definitions as started in #581. * fixup! refactor: move syntax grammars to TS definitions
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #571:
yarn build:syntaxes)