fix(drawer): respect NoopAnimationsModule and @.disabled binding
#12839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
target: major
devversion
requested review from
amcdnl,
jelbourn,
josephperrott and
mmalerba
as code owners
googlebot
added
the
cla: yes
devversion
changed the title
devversion
force-pushed
the
fix/missing-comps-disabled-animations
branch
from
e052fd5 to
651188b
Compare
crisbeto
reviewed
Aug 26, 2018
src/lib/badge/_badge-theme.scss
Outdated
| @@ -137,6 +137,10 @@ $mat-badge-large-size: $mat-badge-default-size + 6; | |||
| white-space: nowrap; | |||
| text-overflow: ellipsis; | |||
| pointer-events: none; | |||
|
|
|||
| ._mat-animation-noopable &, .ng-animate-disabled & { | |||
There was a problem hiding this comment.
I've had this one open for a while now that handles the badge: #11408.
There was a problem hiding this comment.
I see, though it does not handle the @.disabled binding and is not aligned with the way we go with #12829.
Same applies for comments below.
I can remove the cases where you already have a PR, but you should update your PRs to respect [@.disabled] then.
src/lib/card/card.scss
Outdated
| @@ -16,6 +16,10 @@ $mat-card-header-size: 40px !default; | |||
| padding: $mat-card-default-padding; | |||
| border-radius: $mat-card-border-radius; | |||
|
|
|||
| &._mat-animation-noopable, &.ng-animate-disabled, .ng-animate-disabled & { | |||
src/lib/chips/chips.scss
Outdated
| @@ -40,6 +40,10 @@ $mat-chip-remove-size: 18px; | |||
| height: $mat-chip-remove-size; | |||
| } | |||
|
|
|||
| &._mat-animation-noopable, &.ng-animate-disabled, .ng-animate-disabled & { | |||
| transition: none; | |||
| @@ -13,6 +13,10 @@ | |||
| transition: margin 225ms $mat-fast-out-slow-in-timing-function; | |||
| border-radius: $border-radius; | |||
|
|
|||
| &._mat-animation-noopable, &.ng-animate-disabled, .ng-animate-disabled & { | |||
| transition: none; | |||
* Custom CSS transitions should not run if the `NoopAnimationsModule` or the `[@.disabled]` binding is being used.
devversion
force-pushed
the
fix/missing-comps-disabled-animations
branch
from
34d7d54 to
71fdd69
Compare
devversion
changed the title
NoopAnimationsModule and @.disabled binding
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatDrawer, if theNoopAnimationsModuleor the[@.disabled]binding is being used.Related to #12829