fix(badge): disable animations when using NoopAnimationsModule #11408

crisbeto · 2018-05-18T20:19:15Z

Fixes the badge transitions not being disabled when using the NoopAnimationsModule.

Relates to #10590.

amcdnl

LGTM

ngbot · 2018-10-02T20:34:52Z

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

Fixes the badge transitions not being disabled when using the `NoopAnimationsModule`. Relates to angular#10590.

angular-automatic-lock-bot · 2019-09-10T14:03:15Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

crisbeto assigned amcdnl May 18, 2018

crisbeto requested a review from amcdnl as a code owner May 18, 2018 20:19

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 18, 2018

amcdnl approved these changes May 20, 2018

View reviewed changes

crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 20, 2018

crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels May 27, 2018

crisbeto mentioned this pull request Aug 26, 2018

fix(drawer): respect NoopAnimationsModule and @.disabled binding #12839

Merged

crisbeto force-pushed the badge-noop-animations branch from fd6761c to 3f1b58c Compare August 29, 2018 20:08

crisbeto force-pushed the badge-noop-animations branch from 3f1b58c to d96ebd0 Compare October 1, 2018 20:07

crisbeto force-pushed the badge-noop-animations branch from d96ebd0 to ca39351 Compare October 2, 2018 20:40

crisbeto requested a review from jelbourn as a code owner October 2, 2018 20:40

jelbourn added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Feb 26, 2019

crisbeto force-pushed the badge-noop-animations branch from ca39351 to f0b0b89 Compare February 26, 2019 21:46

fix(badge): disable animations when using NoopAnimationsModule

2bceb01

Fixes the badge transitions not being disabled when using the `NoopAnimationsModule`. Relates to angular#10590.

crisbeto force-pushed the badge-noop-animations branch from f0b0b89 to 2bceb01 Compare February 27, 2019 09:24

josephperrott merged commit 4614fb8 into angular:master Mar 5, 2019

josephperrott pushed a commit that referenced this pull request Mar 5, 2019

fix(badge): disable animations when using NoopAnimationsModule (#11408)

d894158

angular-automatic-lock-bot bot unassigned amcdnl Sep 10, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(badge): disable animations when using NoopAnimationsModule #11408

fix(badge): disable animations when using NoopAnimationsModule #11408

crisbeto commented May 18, 2018

amcdnl left a comment

ngbot bot commented Oct 2, 2018

angular-automatic-lock-bot bot commented Sep 10, 2019

fix(badge): disable animations when using NoopAnimationsModule #11408

fix(badge): disable animations when using NoopAnimationsModule #11408

Conversation

crisbeto commented May 18, 2018

amcdnl left a comment

Choose a reason for hiding this comment

ngbot bot commented Oct 2, 2018

angular-automatic-lock-bot bot commented Sep 10, 2019