Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chips): disable all animations when using NoopAnimationsModule #11546

Merged
merged 1 commit into from
Jun 13, 2019
Merged

fix(chips): disable all animations when using NoopAnimationsModule #11546

merged 1 commit into from
Jun 13, 2019

Conversation

crisbeto
Copy link
Member

Disables all of the chip animations and transitions when the consumer is using the NoopAnimationsModule. Also cleans up some repetitive code.

Relates to #10590.

@crisbeto crisbeto requested a review from tinayuangao as a code owner May 28, 2018 14:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 28, 2018
josephperrott
josephperrott approved these changes Aug 7, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib/chips/chip.ts Outdated
@@ -231,18 +239,23 @@ export class MatChip extends _MatChipMixinBase implements FocusableOption, OnDes
terminateOnPointerUp: globalOptions.terminateOnPointerUp,
};
}

if (this._animationsDisabled) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be necessary since these animations should automatically run in 0 time a NoopAnimationsModule environment correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RippleRenderer doesn't have access to the ANIMATION_MODULE_TYPE so we have to disable it from here.

@josephperrott josephperrott added pr: lgtm target: patch This PR is targeted for the next patch release labels Aug 7, 2018
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 8, 2018
@ngbot
Copy link

ngbot bot commented Aug 23, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto crisbeto force-pushed the chips-noop-animations branch from 59dd848 to fc58823 Compare August 23, 2018 17:26
@crisbeto crisbeto requested a review from jelbourn as a code owner August 23, 2018 17:26
@crisbeto crisbeto mentioned this pull request Aug 26, 2018
Merged
@ngbot
Copy link

ngbot bot commented Sep 19, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto crisbeto force-pushed the chips-noop-animations branch from fc58823 to 79dec72 Compare September 23, 2018 12:06
@crisbeto crisbeto force-pushed the chips-noop-animations branch from 79dec72 to ef1b161 Compare January 6, 2019 20:29
@crisbeto crisbeto force-pushed the chips-noop-animations branch 2 times, most recently from c9d55d3 to 5eb584b Compare January 22, 2019 22:38
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@andrewseguin andrewseguin added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent G This is is related to a Google internal issue labels May 30, 2019
@crisbeto crisbeto force-pushed the chips-noop-animations branch from 5eb584b to bb2df4d Compare June 11, 2019 05:26
@crisbeto
fix(chips): disable all animations when using NoopAnimationsModule
d167f0d 
Disables all of the chip animations and transitions when the consumer is using the `NoopAnimationsModule`. Also cleans up some repetitive code.

Relates to angular#10590.
@crisbeto crisbeto force-pushed the chips-noop-animations branch from bb2df4d to d167f0d Compare June 11, 2019 05:30
@mmalerba mmalerba merged commit 86c626a into angular:master Jun 13, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@crisbeto @RudolfFrederiksen
fix(chips): disable all animations when using NoopAnimationsModule (a…
3d55767 
…ngular#11546)

Disables all of the chip animations and transitions when the consumer is using the `NoopAnimationsModule`. Also cleans up some repetitive code.

Relates to angular#10590.
andrewseguin pushed a commit that referenced this pull request Jul 2, 2019
@crisbeto @andrewseguin
fix(chips): disable all animations when using NoopAnimationsModule (#…
7fc7da1 
…11546)

Disables all of the chip animations and transitions when the consumer is using the `NoopAnimationsModule`. Also cleans up some repetitive code.

Relates to #10590.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crisbeto @josephperrott @googlebot @mmalerba @tinayuangao @andrewseguin