Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to angular 7.2.1 #14787

Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Jan 10, 2019

Includes:

bazel: flat module misses AMD module name on windows (#27839) (935ce63)
bazel: ng_package creates invalid typings reexport on windows (#27829) (4caf654)
bazel: packager not properly removing amd directives on windows (#27829) (8473d68)
bazel: protractor rule does not run spec files with underscore (#28022) (65e72e9)
bazel: protractor utils cannot start server on windows (#27915) (9de9c8a)
bazel: replay compilation uses wrong compiler for building esm5 (#28053) (cd04513)

@devversion devversion requested a review from jelbourn as a code owner January 10, 2019 17:58
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 10, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 10, 2019
@devversion devversion added blocked This issue is blocked by some external factor, such as a prerequisite PR and removed action: merge The PR is ready for merge by the caretaker labels Jan 10, 2019
@devversion
Copy link
Member Author

Blocked on angular/angular#28053

@devversion devversion force-pushed the build/update-to-angular-7.2.0-resubmit branch from 73b63a4 to 36e0be7 Compare January 17, 2019 17:19
@devversion devversion requested a review from crisbeto as a code owner January 17, 2019 17:19
@devversion devversion force-pushed the build/update-to-angular-7.2.0-resubmit branch 2 times, most recently from 6370921 to d97a600 Compare January 17, 2019 17:26
@devversion devversion changed the title build: update to angular 7.2.0 build: update to angular 7.2.1 Jan 17, 2019
@devversion
Copy link
Member Author

This one is now the update to Angular 7.2.1, but is blocked on getting the CI green in #14854

@devversion devversion removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Jan 17, 2019
@devversion devversion force-pushed the build/update-to-angular-7.2.0-resubmit branch from d97a600 to add0a99 Compare January 17, 2019 20:08
@devversion devversion added action: merge The PR is ready for merge by the caretaker pr: merge safe labels Jan 23, 2019
@mmalerba mmalerba merged commit a36235c into angular:master Jan 29, 2019
mmalerba pushed a commit that referenced this pull request Feb 4, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants