Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

build: add Bazel rules #964

Closed
wants to merge 14 commits into from
Closed

build: add Bazel rules #964

wants to merge 14 commits into from

Conversation

CaerusKaru
Copy link
Member

@CaerusKaru CaerusKaru commented Jan 1, 2019

  • Add Bazel build rules for all entrypoints
  • Add Bazel rules to serve the demo app
  • Add goldens api guard
  • Move from SCSS to CSS for most demo app components
    due to conflict with CLI and Bazel style generation
  • Move testing utilities into core (though not exported with the bundle)
  • Move other utilities into proper packages
  • Create intermediary BaseFlexFlowDirective for use by flex and flex-offset
    and remove unneeded method from BaseDirective2

@CaerusKaru CaerusKaru force-pushed the adam/bazel-dev branch 14 times, most recently from faf3a29 to bee6c95 Compare January 1, 2019 19:25
@CaerusKaru CaerusKaru added this to the 7.0.0-beta.23 milestone Jan 1, 2019
@CaerusKaru CaerusKaru changed the title WIP: build: add Bazel rules build: add Bazel rules Jan 1, 2019
@CaerusKaru
Copy link
Member Author

Technically blocked on getting SSR tests to work with Bazel, but not actually blocked since we have regular SSR tests that run fine at the moment.

@CaerusKaru CaerusKaru force-pushed the adam/bazel-dev branch 2 times, most recently from f61f32d to 2c753be Compare January 2, 2019 03:36
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for the caretaker to presubmit and merge and removed pr: needs review labels Jan 3, 2019
@CaerusKaru CaerusKaru added pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for the caretaker to presubmit and merge pr: merge safe The caretaker can merge this PR without doing a presubmit and removed pr: blocked labels Feb 7, 2019
@CaerusKaru
Copy link
Member Author

Closing this since it would likely need another rewrite to use Bazel v3.0 anyway.

@CaerusKaru CaerusKaru closed this May 10, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build cla: yes pr: merge safe The caretaker can merge this PR without doing a presubmit pr: on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants