Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ng-packagr to version 4 #11622

Merged
merged 2 commits into from
Jul 25, 2018
Merged

update ng-packagr to version 4 #11622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9db88e
feat(@schematics/angular): update `ng-packagr` to version 4
alan-agius4 Jul 22, 2018
2f20082
feat(@angular-devkit/build-ng-packagr): update `ng-packagr` to version 4
alan-agius4 Jul 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 31 additions & 23 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
"mini-css-extract-plugin": "~0.4.0",
"minimatch": "^3.0.4",
"minimist": "^1.2.0",
"ng-packagr": "^3.0.3",
"ng-packagr": "^4.0.0",
"node-sass": "^4.9.1",
"npm-registry-client": "^8.5.1",
"opn": "^5.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_ng_packagr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
"rxjs": "^6.0.0"
},
"peerDependencies": {
"ng-packagr": "^2.2.0 || ^3.0.0 || ^4.0.0-rc.0"
"ng-packagr": "^2.2.0 || ^3.0.0 || ^4.0.0"
}
}
3 changes: 2 additions & 1 deletion packages/schematics/angular/library/files/__projectRoot__/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"fullTemplateTypeCheck": true,
"strictInjectionParameters": true,
"flatModuleId": "AUTOGENERATED",
"flatModuleOutFile": "AUTOGENERATED"
"flatModuleOutFile": "AUTOGENERATED",
"enableResourceInlining": true
},
"exclude": [
"src/test.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/schematics/angular/library/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ function addDependenciesToPackageJson() {
{
type: NodeDependencyType.Dev,
name: 'ng-packagr',
version: '^3.0.0',
version: '^4.0.0',
},
{
type: NodeDependencyType.Dev,
Expand Down
2 changes: 1 addition & 1 deletion packages/schematics/angular/library/index_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ describe('Library Schematic', () => {
const tree = schematicRunner.runSchematic('library', defaultOptions, workspaceTree);

const packageJson = getJsonFileContent(tree, 'package.json');
expect(packageJson.devDependencies['ng-packagr']).toEqual('^3.0.0');
expect(packageJson.devDependencies['ng-packagr']).toEqual('^4.0.0');
expect(packageJson.devDependencies['@angular-devkit/build-ng-packagr'])
.toEqual(latestVersions.DevkitBuildNgPackagr);
});
Expand Down
3 changes: 2 additions & 1 deletion tests/angular_devkit/build_ng_packagr/ng-packaged/projects/lib/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"fullTemplateTypeCheck": true,
"strictInjectionParameters": true,
"flatModuleId": "AUTOGENERATED",
"flatModuleOutFile": "AUTOGENERATED"
"flatModuleOutFile": "AUTOGENERATED",
"enableResourceInlining": true
Copy link
Collaborator Author

@alan-agius4 alan-agius4 Jul 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to properly communicate that if consumers are using ng-packagr v3 when they update to v4 they need to add this flag in their existing tsconfig.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT of checking that this field is missing and adding a warning/error at runtime?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually thinking of switching this option to true by default in ng-packagr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works too, and seems like you have already 👍 ng-packagr/ng-packagr#1021

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah :)

},
"exclude": [
"src/test.ts",
Expand Down