-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ng-packagr to version 4 #11622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The huge changes in package lock is due to, that on master the lock file has been created with npm 5
.
AFAIK, npm 6
is preferred.
@@ -21,7 +21,8 @@ | |||
"fullTemplateTypeCheck": true, | |||
"strictInjectionParameters": true, | |||
"flatModuleId": "AUTOGENERATED", | |||
"flatModuleOutFile": "AUTOGENERATED" | |||
"flatModuleOutFile": "AUTOGENERATED", | |||
"enableResourceInlining": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to properly communicate that if consumers are using ng-packagr
v3
when they update to v4
they need to add this flag in their existing tsconfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT of checking that this field is missing and adding a warning/error at runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually thinking of switching this option to true by default in ng-packagr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works too, and seems like you have already 👍 ng-packagr/ng-packagr#1021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah :)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
update
ng-packagr
to version 4ng-packagr v4 requires that enableResourceInlining needs to be enabled for libraries that contain components
Relates also to #11358