Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ng-packagr to version 4 #11622

Merged
merged 2 commits into from
Jul 25, 2018
Merged

update ng-packagr to version 4 #11622

merged 2 commits into from
Jul 25, 2018

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Jul 22, 2018

update ng-packagr to version 4

ng-packagr v4 requires that enableResourceInlining needs to be enabled for libraries that contain components

Relates also to #11358

@alan-agius4 alan-agius4 changed the title Feat ng packagr v4 update ng-packagr to version 4 Jul 22, 2018
Copy link
Collaborator Author

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The huge changes in package lock is due to, that on master the lock file has been created with npm 5.

AFAIK, npm 6 is preferred.

@@ -21,7 +21,8 @@
"fullTemplateTypeCheck": true,
"strictInjectionParameters": true,
"flatModuleId": "AUTOGENERATED",
"flatModuleOutFile": "AUTOGENERATED"
"flatModuleOutFile": "AUTOGENERATED",
"enableResourceInlining": true
Copy link
Collaborator Author

@alan-agius4 alan-agius4 Jul 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to properly communicate that if consumers are using ng-packagr v3 when they update to v4 they need to add this flag in their existing tsconfig.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT of checking that this field is missing and adding a warning/error at runtime?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually thinking of switching this option to true by default in ng-packagr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works too, and seems like you have already 👍 ng-packagr/ng-packagr#1021

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah :)

@filipesilva filipesilva merged commit 1caf708 into angular:master Jul 25, 2018
@alan-agius4 alan-agius4 deleted the feat_ng-packagr_v4 branch July 26, 2018 04:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants