This repository has been archived by the owner on May 29, 2019. It is now read-only.
refactor(carousel): use ngAnimate #1878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move animation logic into animator This allows animation logic to be overridden through a decorator.
Still assign to the active variable in the scope for now.
Need this because $animate.queue was added in 1.2.12 .
|
+1 great job |
|
This is awesome @chrisirhc. Works great. I'm actually controlling a Foundation 5 "orbit" carousel using this directive. (not my call to go with Foundation) |
|
I checked out |
4 tasks
|
Closing in favor of #2699 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes issues with ngAnimate.
Closes #1350
Need to verify if this fixes #1513 , but it should fix it too.
Should fix #1185 as well.
The reason the chore(demo) commit is here is because ngAnimate currently breaks the carousel, as such, it should only be added to the demo once this PR is merged.
The
carouselAnimatoris used to animate the classes. The class names are configurable by calling$decoratoron the carouselAnimator.Once this PR is merged, we can start merging the other PRs related to animations. This should probably be the first PR in line right after enabling the ngAnimate so that nothing (else) breaks on the demo.