Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buttons in gallery on Apple devices using iOS < 13.x #191

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

andi34
Copy link
Collaborator

@andi34 andi34 commented Nov 8, 2019

Fix #185 & #116

From what i found out:

The problem with .click on iOS is that it unbinds the click event."

(...) using 'click touchstart' will get the desired result. If you console.log(e) your clicks though, you may find that when jquery recognizes touch as a click - you will get 2 actions from click and touchstart.

Good read about the problem having 2 actions from click and touchstart: https://stackoverflow.com/questions/7018919/how-to-bind-touchstart-and-click-events-but-not-respond-to-both/36452427#36452427

Change-Id: Id4b7a02d35512940a73d09c21808ca155816ac97
@andi34 andi34 requested a review from sualko November 8, 2019 19:07
@sualko
Copy link
Collaborator

sualko commented Nov 11, 2019

Do we really want to support legacy devices? At some point you have to make a cut, because otherwise the code will get a mess.

@andi34
Copy link
Collaborator Author

andi34 commented Nov 12, 2019

We're using this code in the core.js already in some parts. And right, at some point we might have to stop the support. Since it's not a big change here I think it's okay to keep the support up.

https://github.com/andreknieriem/photobooth/blob/master/resources/js/core.js#L280-L284

https://github.com/andreknieriem/photobooth/blob/master/resources/js/core.js#L507-L509

@sualko sualko merged commit b09dd56 into master Nov 14, 2019
@andi34 andi34 deleted the fix/apple-buttons branch November 14, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple devices smaller IOS 13.x / Gallery Fullscreenpicture button without function
2 participants