Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0: Gallery Buttons (Print/QRCode) doesn't work on IOS 12 #116

Closed
flighter18 opened this issue Oct 10, 2019 · 15 comments
Closed

v2.0.0: Gallery Buttons (Print/QRCode) doesn't work on IOS 12 #116

flighter18 opened this issue Oct 10, 2019 · 15 comments
Labels
Milestone

Comments

@flighter18
Copy link

If I open a pic in the gallery, the button in the right corner doesn't work except the close button. I uploaded a video:
https://youtu.be/e3e1k_bvFxc

@andi34 andi34 added the bug label Oct 11, 2019
@sualko sualko added this to the v2.0.0 milestone Oct 11, 2019
@sualko sualko closed this as completed in 331d1ef Oct 11, 2019
@flighter18
Copy link
Author

@sualko i checked out your fix:

commit b889e2da19ea30580c9e55f685fe8e7a98166b56 (HEAD)
Merge: 5cee070 331d1ef
Author: raphael.schib <[email protected]>
Date:   Fri Oct 11 17:15:34 2019 +0100

    Merge commit '331d1ef4adeb4269893bb7bdc840fd0b2b1c6ec4' of https://github.com/andreknieriem/photobooth into HEAD

commit 331d1ef4adeb4269893bb7bdc840fd0b2b1c6ec4
Author: sualko <[email protected]>
Date:   Fri Oct 11 15:15:14 2019 +0200

    fix gallery buttons on small screens

    fix #116

but unfortunately it still not working

@andi34
Copy link
Collaborator

andi34 commented Oct 11, 2019

@flighter18 you need to run yarn build again.

Once something is in master branch merged it's enough to git fetch origin && git checkout origin/master && yarn build (you must have cloned from here)

If you've cloned from somewhere else, e.g. from my GitHub or your own fork add this repo as remote: git remote add andreknieriem https://github.com/andreknieriem/photobooth
Now replace origin with andreknieriem in above mentioned commands.

@flighter18
Copy link
Author

flighter18 commented Oct 11, 2019

@andi34
I have done the following

sudo -u www-data -s
git remote add andreknieriem https://github.com/andreknieriem/photobooth
git fetch andreknieriem
git checkout andreknieriem/master
yarn build
exit

but the buttons dosen't work.
Maybe i did a mistake with git?

@andi34
Copy link
Collaborator

andi34 commented Oct 11, 2019

If no error was visible and it was telling git checkout was fine it should be ok. It'll tell you in terminal if it can not checkout because of uncommitted changes for example (in case you made some changes by hand in your source)

@flighter18
Copy link
Author

@andi34 no error was visible. so I think the button does still not work.

@andi34
Copy link
Collaborator

andi34 commented Oct 11, 2019

You can check git log if latest commit hash matches the one here, should be 331d1ef4adeb4269893bb7bdc840fd0b2b1c6ec4 if you're not sure

@flighter18
Copy link
Author

@andi34 thank you for this hint.

[root@raspberrypi:/var/www/html# git log
commit 331d1ef4adeb4269893bb7bdc840fd0b2b1c6ec4 (HEAD, andreknieriem/master)
Author: sualko <[email protected]>
Date:   Fri Oct 11 15:15:14 2019 +0200]

So it matches.

@andi34
Copy link
Collaborator

andi34 commented Oct 11, 2019

You're able to test on Android?
Only specific browser?

@flighter18
Copy link
Author

i do not have any android device but i tested it with 3 browser on ipad and iphone.
none of them works.

@andi34
Copy link
Collaborator

andi34 commented Oct 11, 2019

Ok. Might be able to check in the morning on Android. Will have to setup my pi again as access point for it.

@andi34
Copy link
Collaborator

andi34 commented Oct 11, 2019

Quickly tested 😂 no issues on my phone , Android 9, Chrome browser, OnePlus 6.

Screenshot_20191011-210833

Screenshot_20191011-210823

Screenshot_20191011-210818

Screenshot_20191011-210804

Screenshot_20191011-210750
Screenshot_20191011-210655

Screenshot_20191011-210649

Screenshot_20191011-210852

@flighter18
Copy link
Author

I tested it now also on IOS 13. here it works too 🙈. So the problem is IOS 12

@flighter18
Copy link
Author

🥴 my ipad is to old for IOS13 😅 shit

@andi34
Copy link
Collaborator

andi34 commented Oct 11, 2019

@andi34
Copy link
Collaborator

andi34 commented Oct 14, 2019

on click vs on touchstart?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants