-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for first release #67
Conversation
Now we have released wheels for python 3.11 and 3.12
8471dbd
to
9463d31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR ready for review. Required to push conda-forge/staged-recipes#24630 through. We can add the conda installation instructions in the new main (will be included in the next release, not a big deal). |
@diegoferigo we should bump also this https://github.com/ami-iit/jaxsim/blob/main/src/jaxsim/version.txt or find a different solution |
I missed that file, I had no idea it was there. We can generate it with |
This comment was marked as outdated.
This comment was marked as outdated.
Would that be enough for readthedocs? I don't like hardcoded data since there is almost 100% chance to forget to update it. I just checked, jaxsim on first_release via 🐍 v3.11.7 🅒 /jaxsim
❯ cat src/jaxsim/version.py
# file generated by setuptools_scm
# don't change, don't track in version control
TYPE_CHECKING = False
if TYPE_CHECKING:
from typing import Tuple, Union
VERSION_TUPLE = Tuple[Union[int, str], ...]
else:
VERSION_TUPLE = object
version: str
__version__: str
__version_tuple__: VERSION_TUPLE
version_tuple: VERSION_TUPLE
__version__ = version = '0.1.dev398+dirty'
__version_tuple__ = version_tuple = (0, 1, 'dev398', 'dirty') If readthedocs is not capable of reading this file, we can just add the following in the
Anyway, is this necessary? Have you tried https://stackoverflow.com/a/61175918? |
What about doing something like this in import requests
# Make an API call to get the latest release information
response = requests.get("https://api.github.com/repos/ami-iit/jaxsim/releases/latest")
data = response.json()
# Get the version from the response
version = data["tag_name"].replace("v", "") In this way |
Mmh I don't like this either, readthedocs can also render documentation from branches and old releases. The version should be directly inferred either from the sources or the corresponding python package. I like #67 (comment) since it always expose |
It should be enough, I tried it locally and I added docs rebuild in CI so we can be sure |
0957a67
to
870597d
Compare
870597d
to
f221d59
Compare
jax
, particularly, let's try to keep a good upstream alignment since the availability of new features might be useful on the long term.Some comment:
Notes:
setup.cfg
and include all the information intopyproject.toml
.