Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove *ContactsState classes #256

Merged
merged 11 commits into from
Oct 7, 2024
Merged

Remove *ContactsState classes #256

merged 11 commits into from
Oct 7, 2024

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Oct 7, 2024

In the past few months, JaxSim has received numerous updates and additions to contact management. We now have three contact models (soon four), and the only one that requires to extend the ODE state vector that is integrated with the floating-base dynamics is the original SoftContacts model.

  • This PR generalizes how additional variables can be introduced to the integrated state vector.
  • The material deformation $\mathbf{m}$ used by the SoftContacts model is now treated as an augmented ODE state.
  • This generalization allow users to use our integrators with their own custom dynamics (potentially including additional effects not currently considered in JaxSim, e.g. actuator dynamics and muskolo-skeletal models).

📚 Documentation preview 📚: https://jaxsim--256.org.readthedocs.build//256/

It removes the need of having a custom contact state related to the ODE system, which is only needed by specific contact models.
@diegoferigo diegoferigo self-assigned this Oct 7, 2024
@diegoferigo diegoferigo requested a review from xela-95 October 7, 2024 08:32
@diegoferigo diegoferigo force-pushed the remove_contact_state branch from f9cdc2c to f34a845 Compare October 7, 2024 08:36
@diegoferigo diegoferigo marked this pull request as ready for review October 7, 2024 08:36
@diegoferigo diegoferigo force-pushed the remove_contact_state branch from f34a845 to 109d5b1 Compare October 7, 2024 08:44
Copy link
Collaborator

@flferretti flferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Diego! This is great. I just left a single minor comment

src/jaxsim/api/data.py Outdated Show resolved Hide resolved
Copy link
Member

@xela-95 xela-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @diegoferigo !! I just left a minor comment

src/jaxsim/rbda/contacts/rigid.py Outdated Show resolved Hide resolved
Co-authored-by: Filippo Luca Ferretti <[email protected]>

Co-authored-by: Alessandro Croci <[email protected]>
@diegoferigo diegoferigo force-pushed the remove_contact_state branch from 840205a to 5d775de Compare October 7, 2024 09:30
@diegoferigo diegoferigo merged commit 4d85117 into main Oct 7, 2024
24 checks passed
@diegoferigo diegoferigo deleted the remove_contact_state branch October 7, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants