-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove *ContactsState
classes
#256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It removes the need of having a custom contact state related to the ODE system, which is only needed by specific contact models.
diegoferigo
force-pushed
the
remove_contact_state
branch
from
October 7, 2024 08:36
f9cdc2c
to
f34a845
Compare
diegoferigo
force-pushed
the
remove_contact_state
branch
from
October 7, 2024 08:44
f34a845
to
109d5b1
Compare
flferretti
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Diego! This is great. I just left a single minor comment
xela-95
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement @diegoferigo !! I just left a minor comment
Co-authored-by: Filippo Luca Ferretti <[email protected]> Co-authored-by: Alessandro Croci <[email protected]>
diegoferigo
force-pushed
the
remove_contact_state
branch
from
October 7, 2024 09:30
840205a
to
5d775de
Compare
flferretti
approved these changes
Oct 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past few months, JaxSim has received numerous updates and additions to contact management. We now have three contact models (soon four), and the only one that requires to extend the ODE state vector that is integrated with the floating-base dynamics is the original
SoftContacts
model.SoftContacts
model is now treated as an augmented ODE state.📚 Documentation preview 📚: https://jaxsim--256.org.readthedocs.build//256/