Restacks the 1.1 system symbol and macro tables #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
commented
Dec 11, 2024
| @@ -284,7 +285,7 @@ impl<'top, D: Decoder> LazyExpandedStruct<'top, D> { | |||
| } | |||
| // For any other kind of struct, do a linear scan over its fields until we encounter | |||
| // one with the requested name. | |||
| _ => { | |||
| ValueLiteral(..) | MakeField(..) | MakeStruct(..) => { | |||
There was a problem hiding this comment.
🪧 This change addresses feedback from the previous PR by making the remaining kinds of struct explicit.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
=======================================
Coverage 77.81% 77.81%
=======================================
Files 136 136
Lines 34656 34656
Branches 34656 34656
=======================================
Hits 26966 26966
Misses 5690 5690
Partials 2000 2000 ☔ View full report in Codecov by Sentry. |
jobarr-amzn
approved these changes
Dec 11, 2024
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.