-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements the make_field
system macro
#878
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
==========================================
+ Coverage 77.79% 77.81% +0.01%
==========================================
Files 136 136
Lines 34533 34656 +123
Branches 34533 34656 +123
==========================================
+ Hits 26864 26966 +102
- Misses 5678 5690 +12
- Partials 1991 2000 +9 ☔ View full report in Codecov by Sentry. |
// For any other kind of struct, do a linear scan over its fields until we encounter | ||
// one with the requested name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// For any other kind of struct, do a linear scan over its fields until we encounter | |
// one with the requested name. | |
// For any other kind of struct (e.g. struct literal or make_struct call), | |
// do a linear scan over its fields until we encounter one with the requested name. |
I like a reminder of what the other cases are. It doesn't have to come this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to incorporate this in another PR I'm about to open.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.