Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements the make_field system macro #878

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Implements the make_field system macro #878

merged 4 commits into from
Dec 11, 2024

Conversation

zslayton
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 75.97403% with 37 lines in your changes missing coverage. Please review.

Project coverage is 77.81%. Comparing base (4ac3e78) to head (6db49c5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lazy/expanded/macro_evaluator.rs 75.65% 19 Missing and 9 partials ⚠️
src/lazy/expanded/struct.rs 75.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
+ Coverage   77.79%   77.81%   +0.01%     
==========================================
  Files         136      136              
  Lines       34533    34656     +123     
  Branches    34533    34656     +123     
==========================================
+ Hits        26864    26966     +102     
- Misses       5678     5690      +12     
- Partials     1991     2000       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zslayton zslayton marked this pull request as ready for review December 11, 2024 19:50
Comment on lines +285 to +286
// For any other kind of struct, do a linear scan over its fields until we encounter
// one with the requested name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// For any other kind of struct, do a linear scan over its fields until we encounter
// one with the requested name.
// For any other kind of struct (e.g. struct literal or make_struct call),
// do a linear scan over its fields until we encounter one with the requested name.

I like a reminder of what the other cases are. It doesn't have to come this way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to incorporate this in another PR I'm about to open.

@zslayton zslayton merged commit fd97f5d into main Dec 11, 2024
34 of 35 checks passed
@zslayton zslayton deleted the make-field branch December 11, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants