Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0.0 #393

Merged
merged 3 commits into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 5.0.0

- BREAKING: Update rubocop-rspec to 3.0 which enables by default previously pending cops. See [rubocop-rspec's changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md#300-2024-06-11) for details.

# 4.18.0

* Drop support for Ruby 3.0
Expand Down
6 changes: 0 additions & 6 deletions config/capybara.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,3 @@ require: rubocop-capybara
# scenario.
Capybara:
Enabled: true

# We don't want this cop outside of feature or system specs though.
RSpec/Dialect:
Exclude:
- 'spec/features/**/*.rb'
- 'spec/system/**/*.rb'
17 changes: 17 additions & 0 deletions config/rspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,20 @@ RSpec/ContextWording:
- without
- and
- but

# Within GOV.UK we use Capybara test method syntax of feature,
# scenario.
# We don't want this cop outside of feature or system specs though.
RSpec/Dialect:
# Disables all Capybara-specific methods that have the same native
# RSpec method (e.g. are just aliases)
PreferredMethods:
background: :before
scenario: :it
xscenario: :xit
given: :let
given!: :let!
feature: :describe
Exclude:
- 'spec/features/**/*.rb'
- 'spec/system/**/*.rb'
2 changes: 1 addition & 1 deletion rubocop-govuk.gemspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Gem::Specification.new do |spec|
spec.name = "rubocop-govuk"
spec.version = "4.18.0"
spec.version = "5.0.0"
spec.authors = ["Government Digital Service"]
spec.email = ["[email protected]"]

Expand Down