Release 5.0.0 #393
Release 5.0.0 #393
Conversation
This is a more appropriate place for it after `RSpec/Capybara/FeatureMethods` cop was migrated to RSpec/Dialect.
so that all Capybara-specific methods that have the same native RSpec method (e.g. are just aliases) following the upgrade to rubocop-rspec 3.0. See: - https://github.com/rubocop/rubocop-rspec/pull/1848/files - rubocop/rubocop-rspec@1fa9ce3 > If you were previously using the ‘RSpec/Capybara/FeatureMethods` cop and want to keep disabling all Capybara-specific methods that have the same native RSpec method (e.g. are just aliases), use the following config: > > ``` > RSpec/Dialect: > PreferredMethods: > background: :before > scenario: :it > xscenario: :xit > given: :let > given!: :let! > feature: :describe > ```
|
@baisa, @ryanb-gds this release enables a lot of new cop, which will be flag up in your apps. Would you like to test the branch first and consider any additional config changes we may want to add as part of this release? |
It's probably not something we're going to have time to do in the next couple of weeks, and I'm not generally a fan of overriding linter configs anyway, so I'm inclined to say "no" and we'll come back to you if there's anything that's going to cause us serious trouble? [EDIT]: Given Whitehall appears to have not had any major issues I'd imagine it won't be too bad. |
|
Thanks. In such case I'm merging it. |
We may want to do a pre release to update config for the new cops.
Tested against:
*Failing with previously pending cops are now enabled by default: RSpec/BeEmpty, RSpec/BeEq, RSpec/BeNil, RSpec/ChangeByZero, RSpec/ClassCheck, RSpec/ContainExactly, RSpec/DuplicatedMetadata, RSpec/EmptyMetadata, RSpec/EmptyOutput, RSpec/Eq, RSpec/ExcessiveDocstringSpacing, RSpec/ExpectInLet, RSpec/IdenticalEqualityAssertion, RSpec/IndexedLet, RSpec/IsExpectedSpecify, RSpec/MatchArray, RSpec/MetadataStyle, RSpec/NoExpectationExample, RSpec/PendingWithoutReason, RSpec/ReceiveMessages, RSpec/RedundantAround, RSpec/RedundantPredicateMatcher, RSpec/RemoveConst, RSpec/RepeatedSubjectCall, RSpec/SkipBlockInsideExample, RSpec/SortMetadata, RSpec/SpecFilePathFormat, RSpec/SpecFilePathSuffix, RSpec/SubjectDeclaration, RSpec/UndescriptiveLiteralsDescription, and RSpec/VerifiedDoubleReference