Highlight the "Manuals" header link on manual pages #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at how other apps work (e.g. Travel Advice Publisher) the "Manuals" link should be active when on any of the pages under `/manuals`.
Thanks Ryan—feel free to merge whenever 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The "Manuals" link in the header displayed on pages using the design system should be active when on any of the pages under
/manuals(currently the only such page that uses the design system layout is the publish confirmation page).Why
Looking at how other apps work (e.g. Travel Advice Publisher) this is how the header navbar links should appear, so this brings Manuals Publisher in line with that.
Visuals
Before
After
Trello
This is just a small part of working on the story to migrate the overview page for a manual to the design system.
Follow these steps if you are doing a Rails upgrade.