Merge pull request #2143 from alphagov/consolidation-navbar-manuals-h…

…ighlight Highlight the "Manuals" header link on manual pages
alphagov · Aug 29, 2023 · b823d38 · b823d38
2 parents 82a0c14 + a974222
commit b823d38
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/app/helpers/navigation_helper.rb b/app/helpers/navigation_helper.rb
@@ -1,7 +1,7 @@
 module NavigationHelper
   def navigation_links_internal
     links = [
-      { text: "Manuals", href: manuals_path, active: request.path == manuals_path },
+      { text: "Manuals", href: manuals_path, active: request.path.starts_with?(manuals_path) },
     ]
     if Time.zone.today < Date.new(2023, 11, 1)
       links << { text: "What's new", href: whats_new_path, active: request.path == whats_new_path }

diff --git a/spec/helpers/navigation_helper_spec.rb b/spec/helpers/navigation_helper_spec.rb
@@ -17,10 +17,16 @@
       end
     end
 
-    it "sets the link to the current page as active" do
+    it "sets the link to the manuals page as active when on the manuals index page" do
       request.path = manuals_path
       expect(navigation_links_internal).to include(a_hash_including(text: "Manuals", active: true))
     end
+
+    it "sets the link to the manuals page as active when on a manual's view page" do
+      manual = FactoryBot.build_stubbed(:manual)
+      request.path = manual_path(manual)
+      expect(navigation_links_internal).to include(a_hash_including(text: "Manuals", active: true))
+    end
   end
 
   describe "#navigation_links_auth" do