chore: make Header encoding good #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
mattsse
requested changes
Oct 18, 2024
Rjected
force-pushed
the
dan/fix-header-encoding
branch
from
3b33ca4 to
2f47316
Compare
mattsse
reviewed
Oct 18, 2024
Rjected
force-pushed
the
dan/fix-header-encoding
branch
from
2f47316 to
b71b71b
Compare
mattsse
approved these changes
Oct 18, 2024
2 tasks
lwedge99
pushed a commit
to sentioxyz/alloy
that referenced
this pull request
Jan 3, 2025
* chore: make Header encoding good * Update crates/consensus/src/header.rs --------- Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previous code had a bunch of incorrect placeholders only required for arbitrary impls that output incorrect headers.
Solution
Remove the placeholders
PR Checklist