Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #31

Merged
merged 7 commits into from
May 8, 2017
Merged

Improvements #31

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
589b967
Update to new cefpython API, drop obsolete code, adhere to PEP8, and …
allestuetsmerweh Apr 27, 2017
8e98eea
[Change] Update version: So we the CIS can build a new package
jegger May 8, 2017
e69707c
[Change] Update cefpython to 57.0; Set log-severity to default (erro…
jegger May 8, 2017
a892fa0
[Fix] CertificateError handler
jegger May 8, 2017
829f2ea
[Change] disable downloads
jegger May 8, 2017
04651af
[Fix] windows keyboard-mapping: Basic letters could only be written i…
jegger May 8, 2017
3f70e05
[Fix] (dirty) prevent users from upload dialogs (via js)
jegger May 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions cefbrowser/cefkeyboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,6 @@ def get_windows_key_code(self, kivycode):
# OnPreKeyEvent info for key events and replacate it here.
# (key codes can also be found on MSDN Virtual-key codes page)

# Must map basic letters, otherwise eg. ctrl+a to select all
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cztomczak Do you remember what this exactly does?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ctrl+a selects all text on a web page - check if it works after that code was removed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on context ctrl+a may select all text in a form

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not work before (and does not work with this bit of code removed). Maybe it was working some time ago. We never used this feature - so we never tested it - so I sadly have no idea when (I) broke that. But thanks for the clarification.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly you removed some other code and it broke. It works in kivy_.py example in cefpython.

# text won't work. (97-122 kivy <> 65-90 cef)
if 97 <= kivycode <= 122:
cefcode = kivycode - 32

other_keys_map = {
# Escape
"27": 27,
Expand Down