Improvements #31
Improvements #31
Conversation
allestuetsmerweh
commented
Apr 27, 2017
allestuetsmerweh
commented
- Move to Python 3
- Adhere to PEP8
- Update to new cefpython API
- Drop obsolete code
| windowInfo.SetAsOffscreen(wid) | ||
| Logger.debug("Use window handle %s, because: %s", window_id, e) | ||
| window_info = cefpython.WindowInfo() | ||
| window_info.SetAsOffscreen(window_id) |
There was a problem hiding this comment.
There have been modifications in cefpython's Print functionality. Printing should now work even when parent window handle is not provided in SetAsOffscreen. However I don't remember if window handle was also required for other reasons, whether it is required for mouse context menu and popup widgets to work correctly.
| message_text, | ||
| default_prompt_text, | ||
| callback, | ||
| suppress_message, |
There was a problem hiding this comment.
In case you haven't seen, you can now remove unused args from callbacks signature and use **kwargs, see: https://github.com/cztomczak/cefpython/blob/master/docs/Migration-guide.md#v553-handlers-callbacks-and-other-interfaces
cefbrowser/cefbrowser.py
Outdated
| def OnAddressChange(self, browser, frame, url): | ||
| if browser.GetMainFrame()==frame: | ||
| def OnAddressChange(self, browser, frame, url): # noqa: N802 | ||
| if browser.GetMainFrame() == frame: |
There was a problem hiding this comment.
This could be written: frame.IsMain().
Also do not compare browser/frame objects using == operator, because there are some edge cases when this doesn't work. Always use GetIdentifier() on these objects.
|
Thanks, @cztomczak . I'm not available over the prolonged weekend, so I'll look into adjustments afterwards also awaiting @jegger 's review. |
…) (to not spam the log by default); Disable context-menu as the diaplyed options are not something we want (less is more, end users do not need this functionality in our apps).
| @@ -2,4 +2,4 @@ | |||
| # 1) we don't load dependencies by storing it in __init__.py | |||
| # 2) we can import it in setup.py for the same reason | |||
| # 3) we can import it into your module module | |||
| __version__ = '0.5.57' | |||
There was a problem hiding this comment.
@jegger you want to change that together with the rest of the PR? Or did you just want to push this to master?
There was a problem hiding this comment.
Together with the rest of this PR.
|
We need a way to suppress the gtk file dialog at file upload. The dialog must have been introduced in one of the newer cefpython versions. The rest seems to be running fine (did not test it with Py3 tough). |
|
http://magpcss.org/ceforum/apidocs3/projects/(default)/CefDialogHandler.html @cztomczak |
…n capital. However I do not know if removing this breaks existing functionality. => Ctrl+a did not work before either...
| @@ -192,11 +192,6 @@ def get_windows_key_code(self, kivycode): | |||
| # OnPreKeyEvent info for key events and replacate it here. | |||
| # (key codes can also be found on MSDN Virtual-key codes page) | |||
|
|
|||
| # Must map basic letters, otherwise eg. ctrl+a to select all | |||
There was a problem hiding this comment.
@cztomczak Do you remember what this exactly does?
There was a problem hiding this comment.
ctrl+a selects all text on a web page - check if it works after that code was removed
There was a problem hiding this comment.
Depending on context ctrl+a may select all text in a form
There was a problem hiding this comment.
Did not work before (and does not work with this bit of code removed). Maybe it was working some time ago. We never used this feature - so we never tested it - so I sadly have no idea when (I) broke that. But thanks for the clarification.
There was a problem hiding this comment.
Possibly you removed some other code and it broke. It works in kivy_.py example in cefpython.
|
File dialog default implementation added here: You can create a new issue to expose DialogHandler and its OnFileDialog callback, to be able to suppress it. |
allestuetsmerweh
force-pushed
the
update_py3_pep8_api
branch
from
794548a to
3f70e05
Compare
