Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Fix conditions on which the prompt asking the user to save a project before submitting it to the render farm relies #1942

Merged
merged 1 commit into from
Mar 21, 2023
Merged

[ui] Fix conditions on which the prompt asking the user to save a project before submitting it to the render farm relies #1942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions meshroom/ui/qml/main.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,17 +184,9 @@ ApplicationWindow {

property bool warnIfUnsaved: true

// evaluate if global reconstruction computation can be started
property bool canStartComputation: _reconstruction ?
_reconstruction.viewpoints.count >= 2 // at least 2 images
&& !_reconstruction.computing // computation is not started
&& _reconstruction.graph.canComputeLeaves : // graph has no uncomputable nodes
false

// evaluate if graph computation can be submitted externally
property bool canSubmit: _reconstruction ?
_reconstruction.canSubmit // current setup allows to compute externally
&& canStartComputation // can be computed
&& _reconstruction.graph.filepath : // graph is saved on disk
false

Expand Down