Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import package statement position and doc comment details to pass checkstyle plugin #2621

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

TrevorLink
Copy link
Contributor

Describe what this PR does / why we need it

When building the latest SCA cloned from github via maven, some of the SCA components (such as Nacos and RocketMQ) do not pass the checkstyle check and report an error

Does this pull request fix one issue?

Fixes #2620

Describe how you did it

Check the checkstyle-result.xml file in the target directory to locate the specific line where the class does not meet the code specification

Describe how to verify it

Modify the code according to the error message by following the row and column positions indicated by the error tag in the checkstyle-result.xml in the target directory
Afterwards, run mvn clean install -DskipTests to confirm that the checkstyle plugin checks out

@CLAassistant
Copy link

CLAassistant commented Jun 25, 2022

CLA assistant check
All committers have signed the CLA.

@steverao
Copy link
Collaborator

LGTM.

@steverao steverao merged commit 2b2776b into alibaba:2.2.x Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some code in example demo of Nacos and RocketMQ can not pass checkstyle plugin when building SCA
3 participants