Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code in example demo of Nacos and RocketMQ can not pass checkstyle plugin when building SCA #2620

Closed
TrevorLink opened this issue Jun 25, 2022 · 0 comments · Fixed by #2621

Comments

@TrevorLink
Copy link
Contributor

Which Component
Example demo ——Nacos ,RocketMQ
Starters——Nacos

Describe the bug
When building the latest SCA cloned from github via maven, some of the SCA components (such as Nacos and RocketMQ) do not pass the checkstyle check and report an error

To Reproduce

  1. git clone
  2. mvn clean install -Dcheckstyle.skip=true -DkipTests
  3. The terminal shows there are some lines in some of classes of SCA components(Nacos Config & RocketMQ) didn't pass the checkstyle plugin due to the codes in the component does not match the code style(the unused import statement , missing @return annotation in doc comments)

Expected behavior
The expected output of the terminal should pass the checkstyle plugin and build success when downloading the dependencies and build SCA core

Additional context
Windows11 、Java8 、 SCA version:2.2.X、maven version:3.3.9

@TrevorLink TrevorLink changed the title Update import statement and doc comment to pass checkstyle plugin when building SCA Some example demo of Nacos and RocketMQ can not pass checkstyle plugin when building SCA Jun 25, 2022
@TrevorLink TrevorLink changed the title Some example demo of Nacos and RocketMQ can not pass checkstyle plugin when building SCA Some code in example demo of Nacos and RocketMQ can not pass checkstyle plugin when building SCA Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant