Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow rocketmq binder with anonymous group. #2464

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Allow rocketmq binder with anonymous group. #2464

merged 3 commits into from
Mar 21, 2022

Conversation

Sorieee
Copy link
Contributor

@Sorieee Sorieee commented Mar 16, 2022 •
edited
Loading

Describe what this PR does / why we need it

  1. Allow rocketmq binder with anonymous group.
  2. Fix NacosConfigEndpointTests instability issues caused by Replace powermock with mockito in Nacos config. #2441

Does this pull request fix one issue?

Fixes #2391

Describe how you did it

  1. When group is null, make group = "anonymous" + {uuid} .
  2. When it is a DLQ, and group is null, throw a RuntimeExpcetion. (According to https://docs.spring.io/spring-cloud-stream/docs/3.2.1/reference/html/spring-cloud-stream.html#spring-cloud-stream-reference)

Describe how to verify it

  1. mvn clean install
  2. Write some unit tests
  3. Run rocketmq-comprehensive-example（make an output group null to test.

Special notes for reviews

Sorieee added 2 commits March 15, 2022 21:40
@Sorieee
Fixs group must be configured for channel alibaba#2391
bd800de 
And delete rocketmq-comprehensive-example's consumer group configurations.
@Sorieee
Write some tests for alibaba#2391
0cd0377
@Sorieee Sorieee changed the title 2021.x sorie rocketmq group Allow rocketmq binder with anonymous group. Mar 16, 2022
@Sorieee Sorieee force-pushed the 2021.x_sorie_rocketmq_group branch from 28eb54a to 154775d Compare March 16, 2022 12:47
@DanielLiu1123 DanielLiu1123 merged commit 2432d64 into alibaba:2021.x Mar 21, 2022
@Sorieee Sorieee mentioned this pull request Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java.lang.RuntimeException: group must be configured for channel
2 participants
@Sorieee @DanielLiu1123