Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace powermock with mockito in Nacos config. #2441

Merged

Conversation

Sorieee
Copy link
Contributor

@Sorieee Sorieee commented Mar 7, 2022

Describe what this PR does / why we need it

Replace powermock with mockito.

Does this pull request fix one issue?

Fixes #2417

Describe how you did it

Mock NacosConfigService::getConfig By Mockito and set it to NacosConfigManager's static field "service".

Describe how to verify it

mvn clean install

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2022

CLA assistant check
All committers have signed the CLA.

@DanielLiu1123 DanielLiu1123 merged commit b09767a into alibaba:2021.x Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nacos Config] Remove powermock dependency
3 participants