Not writing strict violations to todos #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* setting violation-identifier strict in all checkers * recorded violation are not strict
| @@ -147,7 +143,6 @@ struct CheckAllBuilder<'a> { | |||
| } | |||
|
|
|||
| struct FoundViolations { | |||
| checkers: Vec<Box<dyn CheckerInterface + Send + Sync>>, | |||
There was a problem hiding this comment.
Move, pushing this responsibility to make strict a property of the identifier simplifies things quite a bit!
alexevanczuk
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Strict violations always cause
pks checkfailures. There's no need to write out strict violations to "todo" files.Changes
pks update.pks updatewill still exit with0