Setting ViolationIdentifier strict in all checkers
#169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexevanczuk
approved these changes
Mar 21, 2024
perryqh
added a commit
to perryqh/packs
that referenced
this pull request
Mar 21, 2024
* setting violation-identifier strict in all checkers * recorded violation are not strict
alexevanczuk
pushed a commit
that referenced
this pull request
Mar 25, 2024
* Setting ViolationIdentifier `strict` in all checkers (#169) * setting violation-identifier strict in all checkers * recorded violation are not strict * print strict violations in "update"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#166
We need to know if a violation is
strictin order to ignore the violation when writing out todos.Changes
stricttoViolationIdentifierstrictin all of the Checker.check functionsUpcoming PR
strictfield to determine strict mode violations