-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MariaDB #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57ed8ce
to
c5e9a27
Compare
cptanalatriste
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Only minor re-naming suggestions.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MariaDB support, which might also work for a wider array of DBs (sqlite perhaps?).
DSNs
This PR is a breaking change since we now require users to provide the DB connection DSNs (e.g.
postgresql://user:secret@localhost:6789/dbname
) rather than building them fromSRC_DBNAME
,SRC_HOST
,SRC_PASSWORD
, etc.I find this less convenient, as an end user, but I think it's safest as the DSN is all we really need to pass to SQLAlchemy and this change
postgresql://host1:123,host2:456/somedb
Choosing providers
We modify the method of choosing a provider for a given column type. We now use a dict and try to
.get()
a match based on the column type and whether the column has alength
attribute. If that fails, we iterate over all known column types and checkissubclass(our_column_type, dict_column_type)
. This should result in fewerUnsupported type...
runtime errors.Loan tutorial
We add a short tutorial page to describe how to run SSG on this dataset.
SQLite3
Further to my speculation above, I have tested SSG with a simple SQLite3 DB using these env vars:
and it works!